Versions Compared

Old Version 18

changes.mady.by.user Maxim Kuvyrkov

Saved on

compared with

New Version 19

changes.mady.by.user Maxim Kuvyrkov

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • https://reviews.llvm.org/D92515 bumped llvm’s required MSVC version, ironically meaning that clang-cl version 12 and earlier can’t build it. That’s why we need the “ms-fms-compatibility-version" flag to have clang-cl pretend to be a newer MSVC. You don’t need to add -fms-compatibility-versionflag for clang-cl version 13 and later.

  • Known issue with cmake 3.21.1, it builds all try_compile/try_run as debug even if you select release mode. This is why we set “-DCMAKE_TRY_COMPILE_CONFIGURATION=Release”. Not doing so causes a try_run to fail to get error message strings, so lit defaults to Linux strings and a bunch of tests fail.

  • We set LLVM_DEFAULT_TARGET_TRIPLE manually because the prompt we use is an x86 32 bit host prompt. There is no arm64 to arm64 prompt, so cmake detects the host/default target triple “correctly” but it’s not what we really want.

...