Upgrade cppcheck tool in TF-M

Description

Need to upgrade cppcheck tool to v2.6 to include fixes available for the current version. The patch is ready:

https://review.trustedfirmware.org/c/ci/dockerfiles/+/12814

This issue blocks all TF-M jobs as a part of per-patch check:

As a bonus, this is the opportunity to check the correctness of a docker build.

Thanks!

Environment

None

Engineering Progress Update

None

Activity

Glen Valante 
February 15, 2022 at 10:32 PM

Bulk close of resolved issues.

Xinyu Zhang 
January 20, 2022 at 7:41 AM

The upgraded CppCheck works well now. Thanks!

Paul Sokolovskyy 
January 19, 2022 at 8:47 PM

For reference, I did a couple of manual TF-M builds:

  • (FILTER_GROUP=debug)

  • (default FILTER_GROUP)

and they are ok. In the individual config sub-builds, I don’t see mentioning of Ninja or cppcheck, but hope they’re ok. If any issues are spotted please open a ticket.

Paul Sokolovskyy 
January 19, 2022 at 5:47 PM

As you know, there is a special job ( ) intended to check the status of CI health. This can be used as an indicator of successful change in infrastructure.

I have to admit that I don’t know (making only first steps with TF-M CI ). It seems that 2 builds of that job for today are broken.

Anyway, cppcheck in TF-M image (the title of this ticket) was upgraded now, so closing.

Anton Komlev 
January 19, 2022 at 4:52 PM

Thanks, Paul. I have permission and merged the patch. Generally, I would minimise the use of that power, having not enough knowledge and view on how this infrastructure works.

As you know, there is a special job ( ) intended to check the status of CI health. This can be used as an indicator of successful change in infrastructure.

Done

Details

Assignee

Reporter

Labels

Upstream

Components

Priority

Checklist

Sentry

Created January 18, 2022 at 3:11 PM
Updated February 15, 2022 at 10:32 PM
Resolved January 19, 2022 at 5:48 PM