Gerrit Query Limit for TF-A Tests project

Description

I’m using gerrit query ( ) to data mine information about changes going across various repos and am having difficulty with https://review.trustedfirmware.org/q/project:TF-A/tf-a-tests,225 where I cannot retrieve information beyond the last 225 changes even though the project has many more changes beyond that.

I don’t have this issue with other repos, or as yet not have hit the limit.

I’m guessing (via google search) this is tied to the “Query Limit” setting? it says the hard coded limit is 500 but that does not seem to be the case. Anyway I was not sure where this setting should be applied as we have a hierarchical inheritance in Access Control.

Can this issue be fixed please.

Environment

None

Engineering Progress Update

The query limit on gerrit was increased to 500 results per page and the server was rebooted, but the change did not address the problem as gerrit doesn't have the data that was being requested.

Activity

Joanna Farley 
June 21, 2022 at 1:15 PM

This can be closed.

Kelley Spoon 
June 21, 2022 at 12:39 PM

Hi Joanna,

No problem.

The key thing for gerrit to identify a change is the ‘Change-Id' line in the commit.msg. It ties the commit in with metadata held in a git note that records comments, votes, patchsets, etc.

If there’s some way to get info for analysis on the non-gerrit commits, it might help to filter out anything with a Change-Id.

Unfortunately, I can’t think of anything clever for getting stats on the pre-gerrit changes.

Going to set this to resolved, and let me know if you have any other issues with gerrit.

Joanna Farley 
June 18, 2022 at 9:26 AM

Thanks Kelly. The use of the Gerrit URL was just a way to demonstrate the issue. I am using gerrit query in some scripts internally developed. Basically they process the JSON into a CSV format to be pulled into excel so we can do some analysis there.

I think the issue is that although the TF-A/tf-a-tests git repo has well over 240 changes as seen by doing a gitlog the “meta data” for Gerrit to show the details of changes and so being able to use thegerrit query capabilities is not there because the Gerrit reviews occurred when the repo was in Arm I suspect.

Thanks for trying, and sorry if I have wasted your time I better understand the relationship between Gerrit and git now on processing the information in git repos.

Kelley Spoon 
June 18, 2022 at 3:59 AM

The ,225 option on the URL you’re using is meant for use with pagination and is telling gerrit to start displaying after the 225th entry.

Gerrit defaults to using 25 results per page of query results unless you use the “limit:X” operator, which is meant for use in the ssh interface and can cause unpredictable results in the web UI.

Since there are 240 results in this query, the web UI is only showing 9 pages as there aren’t enough entries to create a 10th page yet. The 9th page is the final page for these results.

If you’re trying to get around the pagination and just download all 240 results at once, you can use something like this in a script:

ssh -i 29418 spoonix@review.trustedfirmware.org gerrit query --format=JSON --start 0 project:TF-A/tf-a-tests limit:500

 

Which will result in JSON output like this:

Joanna Farley 
June 17, 2022 at 9:30 PM

Hi

TF-A Tests still does not go above 225. https://review.trustedfirmware.org/q/project:TF-A/tf-a-tests,225

TF-A goes to 4475 before hitting the limit https://review.trustedfirmware.org/q/project:TF-A/trusted-firmware-a,4475. This looks like when TF-A moved to Trustedfirmware.org.

I’m not sure if that is the case for TF-A Tests….

Delivered

Details

Assignee

Reporter

Upstream

Components

Priority

Checklist

Sentry

Created June 16, 2022 at 8:50 AM
Updated October 23, 2023 at 1:44 PM
Resolved June 21, 2022 at 12:42 PM